-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(analytics): constrain pagination only to limit query parameter #4012
Merged
shortcuts
merged 2 commits into
main
from
feat/analytics/remove_analytics_pagination_constraint
Oct 21, 2024
Merged
docs(analytics): constrain pagination only to limit query parameter #4012
shortcuts
merged 2 commits into
main
from
feat/analytics/remove_analytics_pagination_constraint
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
febeck
changed the title
refactor(analytics): constrain pagination only to limit query parameter
docs(analytics): constrain pagination only to limit query parameter
Oct 21, 2024
febeck
force-pushed
the
feat/analytics/remove_analytics_pagination_constraint
branch
from
October 21, 2024 12:44
c6ccb3d
to
d11c082
Compare
shortcuts
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good!
can I go ahead and merge?
Thanks @shortcuts, yes you can |
shortcuts
deleted the
feat/analytics/remove_analytics_pagination_constraint
branch
October 21, 2024 14:05
algolia-bot
added a commit
that referenced
this pull request
Oct 21, 2024
…4012) (generated) [skip ci] Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Oct 21, 2024
…generated) algolia/api-clients-automation#4012 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Oct 21, 2024
…generated) algolia/api-clients-automation#4012 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Oct 21, 2024
…generated) algolia/api-clients-automation#4012 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Oct 21, 2024
…generated) algolia/api-clients-automation#4012 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Oct 21, 2024
…generated) algolia/api-clients-automation#4012 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Oct 21, 2024
…generated) algolia/api-clients-automation#4012 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Oct 21, 2024
…generated) algolia/api-clients-automation#4012 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Oct 21, 2024
…generated) algolia/api-clients-automation#4012 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Oct 21, 2024
…generated) algolia/api-clients-automation#4012 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Oct 21, 2024
…generated) algolia/api-clients-automation#4012 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: OPTIM-1314
Changes included:
Update documents to reflect changes in the API brought by https://github.com/algolia/go/pull/16694
offset + limit
combined limit and update documentation to reflect the changes🧪 Test