Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): results in getObjects is required #4024

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

reported by @kombucha when migrating the dashboard api client, see https://algolia.slack.com/archives/C336MP4UA/p1729586897712759?thread_ts=1728917031.913569&cid=C336MP4UA

the results field is always there, but the objects are nullable

@shortcuts shortcuts self-assigned this Oct 23, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 23, 2024

✔️ Code generated!

Name Link
🪓 Triggered by bf6947890300f687c4fa1dae6cc692cd1931c7cc
🍃 Generated commit c1e7505cded4157087258b686f86f9dd74ec2c34
🌲 Generated branch generated/fix/get-objects-response
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1644
go 1636
php 1544
csharp 1247
java 1109
python 1033
ruby 922
swift 760

@shortcuts shortcuts force-pushed the fix/get-objects-response branch from fae87df to 9cb21fc Compare October 23, 2024 08:47
@shortcuts shortcuts marked this pull request as ready for review October 23, 2024 09:10
@shortcuts shortcuts requested a review from a team as a code owner October 23, 2024 09:10
@shortcuts shortcuts enabled auto-merge (squash) October 23, 2024 09:35
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@shortcuts shortcuts merged commit 1f36e8f into main Oct 23, 2024
28 checks passed
@shortcuts shortcuts deleted the fix/get-objects-response branch October 23, 2024 09:35
algolia-bot added a commit that referenced this pull request Oct 23, 2024
…ip ci]

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 23, 2024
algolia/api-clients-automation#4024

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Oct 23, 2024
algolia/api-clients-automation#4024

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 23, 2024
algolia/api-clients-automation#4024

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 23, 2024
algolia/api-clients-automation#4024

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 23, 2024
algolia/api-clients-automation#4024

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 23, 2024
algolia/api-clients-automation#4024

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 23, 2024
algolia/api-clients-automation#4024

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 23, 2024
algolia/api-clients-automation#4024

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 23, 2024
algolia/api-clients-automation#4024

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 23, 2024
algolia/api-clients-automation#4024

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 23, 2024
algolia/api-clients-automation#4024

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants