feat(specs): add estimate path and responses [skip-bc] #4057
+140
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
cdhawke
changed the title
shortcuts
reviewed
Oct 30, 2024
| @@ -0,0 +1,51 @@ | |||
| post: | |||
There was a problem hiding this comment.
you need to reference it in the base spec file
so that it gets generatedThere was a problem hiding this comment.
Thanks I did this locally and forgot to push before I left for the day. I'll send it tomorrow 👍
febeck
previously approved these changes
Oct 31, 2024
|
Hey @cdhawke, let me know if you need any help with the CI |
|
@millotp thanks 😄 - I think i'm just working through getting the test added properly. If this next commit doesn't make some progress i'll reach out - I can't get the yarn cli commands to work locally so i'm just leveraging the CI to tell me what's wrong. |
I would be interested to see which errors you are running into if you have time, this is something we could add to the contribution guides |
|
@millotp - the failure in the CI now is from the java api changing ( |
If this is what the API expect we can allow the breaking change yes |
millotp
changed the title
|
@millotp - feel free to merge this whenever if you're good with it. There's nothing blocking it |
algolia-bot
added a commit
that referenced
this pull request
Nov 7, 2024
…ated) [skip ci] Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Nov 7, 2024
algolia/api-clients-automation#4057 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Nov 7, 2024
algolia/api-clients-automation#4057 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Nov 7, 2024
algolia/api-clients-automation#4057 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Nov 7, 2024
algolia/api-clients-automation#4057 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Nov 7, 2024
algolia/api-clients-automation#4057 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Nov 7, 2024
algolia/api-clients-automation#4057 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Nov 7, 2024
algolia/api-clients-automation#4057 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Nov 7, 2024
algolia/api-clients-automation#4057 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Nov 7, 2024
algolia/api-clients-automation#4057 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Nov 7, 2024
algolia/api-clients-automation#4057 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
millotp
added a commit
that referenced
this pull request
Nov 18, 2024
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
millotp
added a commit
that referenced
this pull request
Nov 18, 2024
…ated) [skip ci] Co-authored-by: Christopher Hawke <69921547+cdhawke@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: OPTIM-1191
Changes included:
/estimatein the abtests endpoints, as well as a new response object definition