chore(java): move the source code to the correct folder #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
|
I really recommend this for those large actions: https://gist.github.com/emiller/6769886 so you don't lose anything (moving file does not exists in git, you lose history as if it was deleted + added) but still manage to apply the changes. Otherwise, we can rely on the CI |
|
Not usable without using push force on main, it's not usable for our setup |
|
I think it works on a branch because you'll merge the history on main but I'm not sure. But since it's the same, we can let the CI do the job. (It will allow allow us to debug if deleted files are correctly pushed) |
millotp
force-pushed
the
chore/move-java-again
branch
from
8f6e66b
to
13278c5
Compare
millotp
force-pushed
the
chore/move-java-again
branch
from
dcecabd
to
77a02b4
Compare
millotp
requested review from
a team,
eunjae-lee and
shortcuts
and removed request for
a team
This was referenced Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
To respect gradle convention and make room for some future test, we move the source code to:
algoliasearch-core/src/main/java/com/algolia(not at all convoluted)🧪 Test
CI