feat(java): replace callbacks by CompletableFuture APIC-421 #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
commented
Apr 28, 2022
millotp
force-pushed
the
feat/java-async
branch
2 times, most recently
from
d9764ec
to
d8344b0
Compare
millotp
requested review from
shortcuts,
aallam,
a team and
damcou
and removed request for
a team
shortcuts
previously approved these changes
May 10, 2022
.github/workflows/check.yml
Outdated
Comment on lines
228
to
230
| run: | | ||
| rm -rf ${{ matrix.client.testsOutputPath }}/client || true | ||
| rm -rf ${{ matrix.client.testsOutputPath }}/methods || true |
There was a problem hiding this comment.
I'd prefer paths being defined in createMatrix to avoid extra logic here, but up to you
shortcuts
reviewed
May 10, 2022
.github/workflows/check.yml
Outdated
| @@ -235,7 +236,7 @@ jobs: | |||
| if: ${{ needs.setup.outputs.RUN_CTS == 'true' }} | |||
| run: | | |||
| git --no-pager diff | |||
There was a problem hiding this comment.
Suggested change
| git --no-pager diff | |
| git --no-pager diff ${{ matrix.client.testsOutputPathToClean }} |
would make the error less confusing
shortcuts
reviewed
May 10, 2022
.github/workflows/check.yml
Outdated
Comment on lines
231
to
232
| exit $(git diff --name-only --diff-filter=d ${{ matrix.client.testsOutputPath }} | wc -l) | ||
|
|
There was a problem hiding this comment.
If we remove this now, there's no way to ensure pushed tests are the ones that runs, I'd rather only remove this when we make the CI push the tests
This was referenced May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: APIC-421
Use
CompletableFutureto make the async function usable, which are widely used by customers.Thanks to @aallam this allows to remove the custom response for
EchoRequesterand simply pass the value by a different route, thus decoupling the test and the client (very good 😄 ).Changes included:
CompletableFutureHttpandEchorequestersInsightsplayground🧪 Test