docs(java): installation guide APIC-419 #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
millotp
requested review from
a team,
eunjae-lee and
shortcuts
and removed request for
a team
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
|
The highlight might be a theme issue because it works on the official Docusaurus doc: https://docusaurus.io/docs/markdown-features/code-blocks#multi-language-support-code-blocks |
|
Even with the light client there is nothing, and there is no mention of it in the redocly doc |
shortcuts
reviewed
May 9, 2022
| ); | ||
| ``` | ||
|
|
||
| Or use a completely different client and specify a region: |
There was a problem hiding this comment.
Suggested change
| Or use a completely different client and specify a region: | |
| Or use a completely different client (some clients might require a `region` parameter): |
|
My review comment is not there D: "Thanks for the doc :D"
This part is handled by Docusaurus, I believe Java should work once #481 (comment) is fixed |
shortcuts
previously approved these changes
May 9, 2022
.github/actions/setup/action.yml
Outdated
| @@ -87,12 +87,12 @@ runs: | |||
| id: gen-matrix | |||
| shell: bash | |||
| run: | | |||
| if [[ steps.diff.outputs.JS_ALGOLIASEARCH_CHANGED > 0 ]]; then | |||
| if [[ $ {{ steps.diff.outputs.JS_ALGOLIASEARCH_CHANGED }} > 0 ]]; then | |||
There was a problem hiding this comment.
ahah I will never understand when the brackets are needed
shortcuts
approved these changes
May 9, 2022
This was referenced May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: APIC-419
Write the installation guide for java.
The syntax highlighting is not working for java and php for some reasons.
🧪 Test
Netlify