fix(java): use Map for query parameters #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
requested review from
eunjae-lee and
damcou
and removed request for
a team
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
commented
May 9, 2022
There was a problem hiding this comment.
@millotp those 3 methods are not used anymore now, I wasn't sure if I should remove them so they are still here for now
Comment on lines
+558
to
+559
| headerParams.put("Accept", "application/json"); | ||
| headerParams.put("Content-Type", "application/json"); |
There was a problem hiding this comment.
Those were in every methods so I've moved them here
Comment on lines
-564
to
-567
| // ensuring a default content type | ||
| if (contentType == null) { | ||
| contentType = "application/json"; | ||
| } |
There was a problem hiding this comment.
Since we set it right above, it can't be null
| @@ -149,6 +149,7 @@ export function create{{capitalizedApiName}}(options: CreateClientOptions{{#hasR | |||
| {{/queryParams.0}} | |||
| {{/bodyParams.0}} | |||
| {{/allParams.0}} | |||
| * @param requestOptions - The requestOptions to send along with the query, they will be merged with the transporter requestOptions. | |||
There was a problem hiding this comment.
This was missing in the JS client
shortcuts
force-pushed
the
fix/java-query-parameters
branch
from
7e4f3b2
to
a0b6c74
Compare
millotp
reviewed
May 10, 2022
damcou
previously approved these changes
May 10, 2022
IIRC yes it was like this in the base template, we've iterate on that but after discussing with Pierre we thought it made more sense to make it match today's type |
This was referenced May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-471
Changes included:
While implementing the
requestOptionsfor Java, I've found that the type of the Query Params were different than the current clients.This PR updates the type of the query params and their related utils/methods/tests.
Also in this PR:
requestOptionJSDoc description for the JS client to the template🧪 Test
CI :D