feat(java): deserialize oneof #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
force-pushed
the
feat/java-deserialize-oneof
branch
from
e9d56d5
to
e25ed4a
Compare
millotp
requested review from
a team,
eunjae-lee and
damcou
and removed request for
a team
millotp
force-pushed
the
feat/java-deserialize-oneof
branch
from
e25ed4a
to
4ab7605
Compare
shortcuts
approved these changes
May 11, 2022
| @@ -32,21 +32,21 @@ runs: | |||
|
|
|||
| # JavaScript utils | |||
| - name: client-javascript-utils-client-common | |||
| if: ${{ inputs.type == 'all' || inputs.type == 'js_utils' }} | |||
| if: ${{ (inputs.javascript == 'true' && inputs.type == 'all') || inputs.type == 'js_utils' }} | |||
This was referenced May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
The deserialization part of one of was not implemented at all, because it's a complicated challenge.
For now it will try to deserialize into every type and returns the first one that matches, which is less than ideal because some type are compatible with others.
The best way to do it would be with some kind of discriminator (available in openapi) but this would only work on object.
🧪 Test
Use the playground with something that returns a oneOf, like
analytics.getTopSearches