fix(java): release package with name algoliasearch-client-java #498
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
I don't think the folder rename is necessary, it just matches the name of the repository it will be hosted, and we plan to remove code from here later anyway.
If you plan to change the repo of destination, I'd suggest you to talk about this with the team, as there might be reasons why we've used the java-2 instead of -java
config/clients.config.json
Outdated
| "folder": "clients/algoliasearch-client-java-2", | ||
| "packageVersion": "0.0.1", | ||
| "folder": "clients/algoliasearch-client-java", | ||
| "packageVersion": "4.0.0", |
There was a problem hiding this comment.
We should maybe not bump this right now, otherwise if you release people will see it and try to use it, no?
(idk how it works on sonatype etc I'm maybe wrong)
|
I've talked with Mouaad about this, the folder name here is irrelevant and the 2 doesn't make sense. |
But it matches the repo of destination, otherwise we could have much simpler names. It's less confusing like that, so you know it has no relation with https://github.com/algolia/algoliasearch-client-java
|
that's why it's a draft ahah I'm not done |
millotp
requested review from
a team,
eunjae-lee and
shortcuts
and removed request for
a team
| @@ -0,0 +1 @@ | |||
| POM_ARTIFACT_ID=algoliasearch-client-java | |||
There was a problem hiding this comment.
wouldn't it be algoliasearch-core if we have multiple package under this repository later?
There was a problem hiding this comment.
it's not planned for now, I'm not sure what the correct package should be called but it won't be algoliasearch-core for now
There was a problem hiding this comment.
Ideally it should be the exact same as today, to avoid losing version history etc. but during this experimental phase it can be whatever indeed.
What do you think of adding the experimental like we did for JS? So it's a bit of warning and less confusing to users
There was a problem hiding this comment.
SNAPSHOT is the same as experimental for user, they cannot see it and have to add a special repository by hand to be able to use it. It's like another package.
| "groupId": "com.algolia", | ||
| "apiPackage": "com.algolia.api", | ||
| "invokerPackage": "com.algolia", | ||
| "modelPackage": "com.algolia.model.search", | ||
| "library": "okhttp-gson", | ||
| "gitRepoId": "algoliasearch-client-java-2", | ||
| "additionalProperties": { | ||
| "packageName": "algoliasearch-client-java-2" | ||
| "packageName": "algoliasearch-client-java" |
There was a problem hiding this comment.
I think it's called algoliasearch in maven in the current version, does it changes something for us to change this name? I don't know how package managers work for Java
There was a problem hiding this comment.
ah algoliasearch-core exists too
this will break the version bump, right?
There was a problem hiding this comment.
packageName is only used for js, I should remove it here but it changes lots of scripts
millotp
force-pushed
the
fix/java-release-name
branch
from
936b8b8
to
36b225f
Compare
millotp
force-pushed
the
fix/java-release-name
branch
from
36b225f
to
ae4d23b
Compare
algolia/api-clients-automation#498 Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
🧭 What and Why
The name of the package was incorrect, use this to rename to everything to
algoliasearch-client-java,Changes included:
algoliasearch-client-java-2toalgoliasearch-client-java(by hand to not remove files)🧪 Test
playground or CTS