Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): correct type for taskID APIC-478 #504

Merged
merged 2 commits into from
May 16, 2022
Merged

fix(specs): correct type for taskID APIC-478 #504

merged 2 commits into from
May 16, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented May 16, 2022

🧭 What and Why

🎟 JIRA Ticket: APIC-478

Move some specs property from parameters to responses, where they belong, and update the type of taskID to 64 bits integer, as well as support for it in the CTS.

🧪 Test

CI

@millotp millotp self-assigned this May 16, 2022
@netlify
Copy link

netlify bot commented May 16, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 8440645
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62821a53c8eceb0008acddab
😎 Deploy Preview https://deploy-preview-504--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 16, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@millotp millotp requested review from a team, damcou and shortcuts and removed request for a team May 16, 2022 09:42
Comment on lines +1 to +4
taskID:
type: integer
format: int64
description: taskID of the task to wait for.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taskID can be used as a parameter too, so I think it make sense to keep it as is

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah no it's the other taskID, the path parameter maybe

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is only one time it's used as a param and it's for getTask, there is no need to put it in common params.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not referring to the correct one

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what you want me to change ahah

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing sorry I should've resolved it, I thought it was the same for the response and path parameter but it's not ahaha I answered my own question :D

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can I get a approval then ? :)

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

@millotp millotp merged commit 340b7bd into main May 16, 2022
@millotp millotp deleted the fix/taskid-type branch May 16, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants