Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): correct mistakes #509

Merged
merged 4 commits into from
May 19, 2022
Merged

fix(specs): correct mistakes #509

merged 4 commits into from
May 19, 2022

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented May 18, 2022

🧭 What and Why

There are spelling mistakes in the code

Changes included:

  • opened every spec file and fixed what my spell checker said was wrong
  • opened the js client common files and fixed what my spell checker said was wrong

🧪 Test

Make sure that any changes I did don't also need to be reflected in file names (as far as I can tell not)

@netlify
Copy link

netlify bot commented May 18, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 892fbd1
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62862ec5d2cf8f000974fd4c
😎 Deploy Preview https://deploy-preview-509--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 18, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@bodinsamuel
Copy link
Contributor

Out of curiosity, what do you use to spellcheck?

millotp
millotp previously approved these changes May 18, 2022
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow I didn't expect that many typo ! Thanks for fixing them :)
BTW there is a git hook that you can install with yarn postinstall, that will prevent commit of generated clients and bundled specs, as they are generated on the CI, not a blocker though

@millotp millotp changed the title fix(spelling): correct mistakes fix(specs): correct mistakes May 18, 2022
@Haroenv
Copy link
Contributor Author

Haroenv commented May 18, 2022

I use https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker @bodinsamuel

@Haroenv Haroenv requested a review from millotp May 18, 2022 11:28
shortcuts
shortcuts previously approved these changes May 18, 2022
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :DD

@bodinsamuel
Copy link
Contributor

Nice thanks @Haroenv

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :kermittyping:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants