Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): improve specs consistency #51

Merged
merged 2 commits into from
Dec 29, 2021
Merged

feat(specs): improve specs consistency #51

merged 2 commits into from
Dec 29, 2021

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-229

Changes included:

  • Add new eslint plugin to lint yaml files in order to make our spec definition more harmonious
  • Adds createdAt, updatedAt, deletedAt generic responses which removes a lot of duplicate responses
  • In some cases, starting a path by ./ was not working, while removing it always work, I've then removed all the uses of ./

🧪 Test

CI :D

@shortcuts shortcuts self-assigned this Dec 28, 2021
damcou
damcou approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice, indeed it removes a lot of duplicates ^^

@shortcuts shortcuts merged commit 70f041f into main Dec 29, 2021
@shortcuts shortcuts deleted the feat/APIC-229/specs-consistency branch December 29, 2021 12:00
@shortcuts shortcuts mentioned this pull request Dec 29, 2021
Merged
@shortcuts shortcuts mentioned this pull request Jan 5, 2022
Merged
shortcuts added a commit that referenced this pull request Apr 22, 2022
@shortcuts
feat(specs): improve specs consistency (#51)
cd2531d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damcou damcou damcou approved these changes

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shortcuts @damcou