-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(specs): rename search
method
#514
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good ! I feel like git is not helping when file are renamed or swapped, the diff is huge
query: '<YOUR_QUERY>', | ||
filters: 'actor:Scarlett Johansson', | ||
}, | ||
requests: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you merge the two calls and use an array like before ? it makes sense now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not wanted to go too deep in the doc changes, just the usage. I have an other task that aims at improving the guides/examples so I will do it in it
## Using the client | ||
|
||
<Tabs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you know if there is a plugin or something to ease the writing of those files ? like either having a separate file for each language, or write the file with sections...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally set the syntax to markdown so I can collapse sections, but I believe there might be plugins indeed
Yep definitely, especially here where there is in fact really small changes |
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-485
Changes included:
To reduce the number of breaking changes, we've decided to rename search methods:
search
(single index search) is now calledsearchSingleIndex
multipleQueries
(multi index search) is now calledsearch
Updates:
🧪 Test
CI :D