feat(java): waitForTask APIC-478 #521
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
requested review from
a team,
damcou and
shortcuts
and removed request for
a team
clients/algoliasearch-client-javascript/packages/client-common/src/createRetryablePromise.ts
Outdated
Show resolved
Hide resolved
| @@ -216,5 +216,19 @@ public class {{classname}} extends ApiClient { | |||
| } | |||
| {{/optionalParams.0}} | |||
| {{/operation}} | |||
|
|
|||
| {{#isSearchClient}} | |||
| public void waitForTask(String indexName, Long taskID, RequestOptions requestOptions) { | |||
There was a problem hiding this comment.
Can we allow option overriding like we did for JS? This way people don't have to re-implement the function
There was a problem hiding this comment.
yep I can add a variant
| import java.util.function.Predicate; | ||
| import java.util.function.Supplier; | ||
|
|
||
| public class TaskUtils { |
There was a problem hiding this comment.
We could maybe add the defaults at the class level? So we don't have to dig if we want to change it somedays
There was a problem hiding this comment.
I did the same as for js, do you want me to change it there too ?
There was a problem hiding this comment.
Yep a constant at the top of the file maybe?
There was a problem hiding this comment.
Sorry you mean putting the default in the search client or just at the top of this file?
There was a problem hiding this comment.
At the top of this file, the default value options (same for JS maybe?)
...lgoliasearch-client-java-2/algoliasearch-core/src/main/java/com/algolia/utils/TaskUtils.java
Outdated
Show resolved
Hide resolved
...lgoliasearch-client-java-2/algoliasearch-core/src/main/java/com/algolia/utils/TaskUtils.java
Outdated
Show resolved
Hide resolved
|
The generation said nope ahah |
🧭 What and Why
🎟 JIRA Ticket: APIC-478
Add the
waitForTaskutil for the search client, and make it generic if we want to use for other task.I modified the maxTrials and timeout based on test, it can up a lot more that 1 seconds to delete a single object.
🧪 Test
There is no test for the waitTask yet, I will integrate with the incoming client test, but it's tested in the playground.