chore: add renovate APIC-490 #522
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
| owner: OWNER, | ||
| title, | ||
| body: `Weekly dependencies update. | ||
| Contributes to #523 |
There was a problem hiding this comment.
I will update this issue number once the renovate dashboard is open
There was a problem hiding this comment.
I won't open things you can try to guess the next number :D
millotp
requested review from
a team,
eunjae-lee and
shortcuts
and removed request for
a team
| "prHourlyLimit": 10, | ||
| "prConcurrentLimit": 50 |
There was a problem hiding this comment.
I'm sure it can handle it 😬
| owner: OWNER, | ||
| title, | ||
| body: `Weekly dependencies update. | ||
| Contributes to #523 |
There was a problem hiding this comment.
I won't open things you can try to guess the next number :D
scripts/release/process-release.ts
Outdated
| @@ -308,7 +305,7 @@ async function processRelease(): Promise<void> { | |||
| )) { | |||
| const { tempGitDir } = await cloneRepository({ | |||
| lang: lang as Language, | |||
| githubToken: process.env.GITHUB_TOKEN, | |||
| githubToken: GITHUB_TOKEN!, | |||
There was a problem hiding this comment.
| githubToken: GITHUB_TOKEN!, | |
| githubToken: GITHUB_TOKEN, |
scripts/common.ts
Outdated
| @@ -26,6 +27,7 @@ export const REPO_URL = `https://github.com/${OWNER}/${REPO}`; | |||
| export const CI = Boolean(process.env.CI); | |||
| export const DOCKER = Boolean(process.env.DOCKER); | |||
| export const BUNDLE_WITH_DOC = process.env.BUNDLE_WITH_DOC === 'true'; | |||
| export const GITHUB_TOKEN = process.env.GITHUB_TOKEN; | |||
There was a problem hiding this comment.
We don't need it we can enforce calling ensureGitHubToken everywhere no?
There was a problem hiding this comment.
| export const GITHUB_TOKEN = process.env.GITHUB_TOKEN; | |
| export const GITHUB_TOKEN = ensureGitHubToken(); |
or maybe?
There was a problem hiding this comment.
no because this file is in a lot of other scripts that don't need the token, we want it to throw only when we need it.
There was a problem hiding this comment.
ahhh I thought it was the release common make sense
| @@ -81,7 +81,7 @@ async function spreadGeneration(): Promise<void> { | |||
| for (const lang of langs) { | |||
| const { tempGitDir } = await cloneRepository({ | |||
| lang, | |||
| githubToken: process.env.GITHUB_TOKEN, | |||
| githubToken: GITHUB_TOKEN!, | |||
There was a problem hiding this comment.
| githubToken: GITHUB_TOKEN!, | |
| githubToken: GITHUB_TOKEN, |
🧭 What and Why
🎟 JIRA Ticket: APCI-490
Add renovate to our repository, only for dev dependencies, not the clients one.
Basically copy pasted the config from the Crawler, it will open a PR every friday and open 1 PR per deps, then merge into
chore/renovateBaseBranchif the CI passes, and then we can review the final PR.Changes included:
GITHUB_TOKENa bit🧪 Test
CI