feat(scripts): consider specs commits for versioning
#523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
requested review from
eunjae-lee and
millotp
and removed request for
a team
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
reviewed
May 20, 2022
| @@ -102,15 +102,17 @@ export function parseCommit(commit: string): Commit { | |||
| message = message.slice(message.indexOf(':') + 1).trim(); | |||
| type = matchResult[1]; | |||
| const lang = matchResult[2] as Language; | |||
| // A spec commit should be added to every clients, as it mostly imply a client change. | |||
| const allowedLanguages = [...LANGUAGES, 'specs']; | |||
There was a problem hiding this comment.
this is not actually lang anymore, but more of a scope, the type above is wrong too, can you rename all of it pls ?
There was a problem hiding this comment.
Ah yes that make sense, especially if we introduce other ones later
This was referenced May 23, 2022
This was referenced May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-493
Changes included:
specscommit are currently considered asunknown-language-scope, while they should bump all languages.specsto the conditions when detecting a commit scope/language🧪 Test
CI :D