chore(deps): ignore clients package #535
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
renovate.json
Outdated
| "**/client-abtesting/**", | ||
| "**/client-analytics/**", | ||
| "**/client-insights/**", | ||
| "**/client-personalisation/**", | ||
| "**/client-predict/**", | ||
| "**/client-query-suggestions/**", | ||
| "**/client-search/**", | ||
| "**/client-sources/**", | ||
| "**/recommend/**" |
There was a problem hiding this comment.
Does it take negative patterns? Might be easier to only ignore manually written clients
There was a problem hiding this comment.
clients/algoliasearch-client-javascript/package.json
clients/algoliasearch-client-javascript/packages/algoliasearch-lite/package.json
clients/algoliasearch-client-javascript/packages/algoliasearch/package.json
clients/algoliasearch-client-javascript/packages/client-abtesting/package.json
clients/algoliasearch-client-javascript/packages/client-analytics/package.json
clients/algoliasearch-client-javascript/packages/client-common/package.json
clients/algoliasearch-client-javascript/packages/client-insights/package.json
clients/algoliasearch-client-javascript/packages/client-personalization/package.json
clients/algoliasearch-client-javascript/packages/client-predict/package.json
clients/algoliasearch-client-javascript/packages/client-query-suggestions/package.json
clients/algoliasearch-client-javascript/packages/client-search/package.json
clients/algoliasearch-client-javascript/packages/client-sources/package.json
clients/algoliasearch-client-javascript/packages/recommend/package.json
clients/algoliasearch-client-javascript/packages/requester-browser-xhr/package.json
clients/algoliasearch-client-javascript/packages/requester-node-http/package.json
eslint/package.json
package.json
playground/javascript/browser/package.json
playground/javascript/node/package.json
scripts/package.json
website/package.json
tests/output/javascript/package.json
10 generated package.json and 12 hand written !
There was a problem hiding this comment.
the tests package is already ignored for some reason
There was a problem hiding this comment.
I meant for the client JS only, like
!clients/algoliasearch-client-javascript/packages/requester-*/**
!clients/algoliasearch-client-javascript/packages/client-common/**
So later we don't have to worry if we add JS clients
There was a problem hiding this comment.
I can try, it doesn't says if it's supported in the doc
There was a problem hiding this comment.
No problem then! Also you can add algoliasearch and algoliasearch-lite to the list if it does not work
There was a problem hiding this comment.
it has to be merged to try 😁
🧭 What and Why
Renovate is trying to update the deps in our generated clients, we don't want that.