fix(java): use addAlgoliaAgent #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
reviewed
Jun 8, 2022
clients/algoliasearch-client-java-2/algoliasearch-core/src/main/java/com/algolia/ApiClient.java
Outdated
Show resolved
Hide resolved
millotp
force-pushed
the
fix/java-useragent
branch
from
0496511
to
98a2a4a
Compare
shortcuts
reviewed
Jun 8, 2022
scripts/ci/husky/pre-commit.js
Outdated
Comment on lines
32
to
34
| if (e.exitCode === 128) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Maybe a small log so we know it happened somewhere, is it for the Netlify issue?
There was a problem hiding this comment.
is netlify providing the var env CI=true ? I think it was another unrelated issue, but I can add the log
There was a problem hiding this comment.
netlify should never call this pre-commit hook anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
As discussed, we already have the option to override the
user-agentby setting the header, so I removed the methodsetAlgoliaAgentin favor ofaddAlgoliaAgentandremoveAlgoliaAgentthat add and remove segments directly.Also removed the generated from
ApiClient.javato make it fully hand written.🧪 Test
CI