fix(scripts): bump playground in release process #690
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
| @@ -13,6 +13,7 @@ | |||
| }, | |||
| "javascript": { | |||
| "folder": "clients/algoliasearch-client-javascript", | |||
| "npmNamespace": "@experimental-api-clients-automation", | |||
There was a problem hiding this comment.
maybe you can simplify packageName in openapitools.json to only be the package name without the @experimental-api-clients-automation
There was a problem hiding this comment.
good idea! let's see if it does the thing 5942a5c
There was a problem hiding this comment.
we could even do more magic by guessing it from the output path but will see
There was a problem hiding this comment.
ah didn't even see buildFile variable lol, it's better like that
There was a problem hiding this comment.
yup!! i'm trying to guess it from the path and we can remove additionalProperties :D
edit: ah no we still need the version
shortcuts
force-pushed
the
fix/scripts-bump-playground
branch
3 times, most recently
from
705ec0b
to
ef24b00
Compare
shortcuts
force-pushed
the
fix/scripts-bump-playground
branch
from
ef24b00
to
9fb7927
Compare
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
package.jsonof the JavaScript playground when running thereleasescript.npmNamespaceto the clients configutilspackage namespace, if you feel like it's not necessary for the gen I can remove it🧪 Test
yarn releasefrom this PR