Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): remove default and strict test APIC-536 #701

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jun 15, 2022

🧭 What and Why

🎟 JIRA Ticket: APIC-536

Remove default from models and let the algolia api set them.
This allows to use STRICT Json assertions in our test, before that we could have more properties than expected.

🧪 Test

CI

@millotp millotp self-assigned this Jun 15, 2022
@netlify
Copy link

netlify bot commented Jun 15, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit f857d53
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62aa083ee7c751000801ff1c

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 15, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@millotp millotp requested review from a team, damcou and shortcuts and removed request for a team June 15, 2022 16:34
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't we did that already? 🤔

@millotp
Copy link
Collaborator Author

millotp commented Jun 16, 2022

We did it in the api.mustache file already yes, passing null when we would have passed a default value before, but it wasn't done in the models

@millotp millotp merged commit 95b5ae7 into main Jun 16, 2022
@millotp millotp deleted the feat/java-default branch June 16, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants