Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): push tags on release #721

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-545

Changes included:

Tags were not pushed to the client's repository on release commit, splitting it in a two-step process like we do for the monorepo should do it.

🧪 Test

CI :D

@shortcuts shortcuts requested a review from a team June 20, 2022 12:55
@shortcuts shortcuts self-assigned this Jun 20, 2022
@shortcuts shortcuts requested review from damcou and millotp and removed request for a team June 20, 2022 12:55
@netlify
Copy link

netlify bot commented Jun 20, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit e598030
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62b06fbbfc88e800099edd71

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 20, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts marked this pull request as ready for review June 20, 2022 13:44
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@shortcuts shortcuts merged commit 9d40ed9 into main Jun 20, 2022
@shortcuts shortcuts deleted the fix/scripts-spread-code branch June 20, 2022 14:08
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jun 20, 2022
algolia/api-clients-automation#721

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants