fix(java): use body as error message APIC-541 #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
millotp
requested review from
a team,
damcou and
shortcuts
and removed request for
a team
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
|
sorry I missed a null check |
shortcuts
reviewed
Jun 23, 2022
| @@ -59,7 +59,7 @@ public Response intercept(Chain chain) throws IOException { | |||
| continue; | |||
| } | |||
| String message = response.message(); | |||
| if (response.body()) { | |||
| if (response.body() != null) { | |||
There was a problem hiding this comment.
TIL my noob self did not knew the short check did not worked 😮💨
shortcuts
approved these changes
Jun 23, 2022
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Jun 23, 2022
algolia/api-clients-automation#734 Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: APIC-541
The message of an error response was just
ForbiddenorBad requestbut we can get more detail through the body if there is one.Changes included:
🧪 Test
Try the playground with the search api key to get an error.