fix(specs): correct type for renderingContent and consequenceParams
#759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
shortcuts
force-pushed
the
fix/specs-renderingContent-consequence
branch
from
6a14111
to
1c4b9c6
Compare
shortcuts
requested review from
a team,
damcou and
millotp
and removed request for
a team
millotp
reviewed
Jun 27, 2022
| automaticOptionalFacetFilters: | ||
| type: object | ||
| description: Same syntax as automaticFacetFilters, but the engine treats the filters as optional. |
There was a problem hiding this comment.
idk if the description will work for this ref, but will see!
There was a problem hiding this comment.
looks like it's working, it's still weird ahah
millotp
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-554
Changes included:
renderingContenttype and properties were wrongconsequenceparamsfield, which was missing hereconsequencewas missing someparamsparameters and had wrong types🧪 Test
CI :D