feat(specs): add abtesting specs and client
#76
Conversation
shortcuts
requested review from
a team and
damcou
and removed request for
a team
clients/algoliasearch-client-javascript/client-abtesting/model/aBTest.ts
Show resolved
Hide resolved
clients/algoliasearch-client-javascript/client-abtesting/model/listABTestsResponse.ts
Show resolved
Hide resolved
| taskID: | ||
| $ref: ../../common/parameters.yml#/taskID |
There was a problem hiding this comment.
Can you remove this one and use the common directly in the spec please ?
There was a problem hiding this comment.
Good catch, forgot to fix that
There was a problem hiding this comment.
Actually I remember why I did that, this in between reference is required when generating client since the path is too deep.
I wonder if this is a limitation of being unable to use built specs.
There was a problem hiding this comment.
I doubt that adding ../ makes the path too deep, and it's never mentioned in the openapi spec
There was a problem hiding this comment.
It works without the in between ref for me
There was a problem hiding this comment.
with just $ref: ../../common/parameters.yml#/taskID ?
There was a problem hiding this comment.
both files are at the same depth there is no reason to fail in one place and not the other
There was a problem hiding this comment.
Yep, I get Could not find taskID in contents of ./paths/../common/parameters.yml
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-201
Changes included:
specsand JavaScript client forabtestingendpontsbodyParams#77) for the Query Suggestions clientclients/README.md🧪 Test
CI :D