-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(specs): Add tags to the settings and search params #768
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very useful thank you !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really great, thanks :D
The final form of the specs (bundled), will transform it in list without quotes, maybe it's worth having the same shape in our non-bundled specs too to avoid confusion?
e.g.
x-categories:
- Languages
- ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! It would be nice on our side to sort them by x-categories
and also maybe sort properties, to make those specs more consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks :D
🧭 What and Why
Tagging search and index params to be able to generate nicer doc from the specs :)
Changes included:
x-category: <list>
on the search and settings paramsThe resulting output of the Algolia CLI
-h
on thesearch
command 👇