fix(specs): make hits required, facets count as an integer, searchParams as optional
#868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
shortcuts
changed the title
hits requiredhits required, correct type for facets
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
bodinsamuel
previously approved these changes
Jul 26, 2022
shortcuts
changed the title
hits required, correct type for facetshits required, facets count as an integer, searchParams as optional
bodinsamuel
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket:
Changes included:
requiredfield forhitswas at the wrong spothitsis required in aSearchResponse, but also aRecommendationsResponsefacetsreturned are aRecord<string, Record<string, number>>searchParamsare optional, therefore we don't need to make it required.🧪 Test
CI :D