-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(specs): rules
and objects
parameters/responses
#876
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
c4d66cf
to
8d7966f
Compare
rules
and objects
parametersrules
and objects
parameters/responses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point of customisation I wonder if we could have chose a different strategy.
E.g: keep the generation simple and wrap with custom code where we would inherit the simple generation and override the methods when needed.
Do you mean for the generic part? I admit that it's a bit cumbersome in some parts. Also, it seems that openapi-generator supports handlebars, which could reduce the logic of those cases |
I think wrapping would have a size impact also :/ which is not ideal for js |
🧭 What and Why
🎟 JIRA Ticket:
Changes included:
Some more specs fixes found during the Crawler implementation.
getObjects
generic as it was in v4distinct
should acceptboolean
as some other parameter of the same shapeRecord<string, any>
🧪 Test
CI :D