Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clients): list available regions when region is missing #916

Merged
merged 3 commits into from
Aug 10, 2022
Merged

fix(clients): list available regions when region is missing #916

merged 3 commits into from
Aug 10, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Aug 10, 2022 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

Suggested by @matthew1809

  • Make missing region error include the available regions.
  • Make PHP client detect missing region parameter when required

🧪 Test

CI :D

@shortcuts shortcuts self-assigned this Aug 10, 2022
@netlify
Copy link

netlify bot commented Aug 10, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit a69ec39
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62f3a639c922ed000822327f

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 10, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts mentioned this pull request Aug 10, 2022
Closed
@shortcuts
Copy link
Member Author

@damcou wdyt of this implem? be6e4f4

damcou
damcou approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement :)

@shortcuts shortcuts enabled auto-merge (squash) August 10, 2022 12:40
@shortcuts shortcuts merged commit 4c1596d into main Aug 10, 2022
@shortcuts shortcuts deleted the fix/clients-clearer-region-throw branch August 10, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damcou damcou damcou approved these changes

@matthew1809 matthew1809 Awaiting requested review from matthew1809

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @damcou