Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cts): friendly error message when a paremeter is not recognized #978

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Aug 31, 2022

🧭 What and Why

Friendly error message when a parameter is not recognized in the CTS, proposing what's accepted.
It can be confusing when it comes from a oneOf because we infer it's type before, and then display all the possibilities, it could also be a wrong match.
Also warning message for list oneOf, which are not well supported.

🧪 Test

Change the name of a param.

@millotp millotp self-assigned this Aug 31, 2022
@netlify
Copy link

netlify bot commented Aug 31, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 18b0c12
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/630f25491cd19400086f1627

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 31, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@millotp millotp requested review from a team, damcou and shortcuts and removed request for a team September 1, 2022 06:40
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@millotp millotp merged commit eb17bd9 into main Sep 1, 2022
@millotp millotp deleted the fix/cts-test-message branch September 1, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants