Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CODEOWNERS #979

Merged
merged 3 commits into from
Sep 1, 2022
Merged

chore: add CODEOWNERS #979

merged 3 commits into from
Sep 1, 2022

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

Seems like the CODEOWNERS file was at the wrong spot, it should now require reviews from us automatically?

🧪 Test

@shortcuts shortcuts self-assigned this Sep 1, 2022
@netlify
Copy link

netlify bot commented Sep 1, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 88fe8d1
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/631073480ac13700083d3274

@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 1, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts enabled auto-merge (squash) September 1, 2022 08:53
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file seemed correct to me before according to the doc, but let's try like that !

@shortcuts shortcuts merged commit 9281022 into main Sep 1, 2022
@shortcuts shortcuts deleted the chore/codeowners branch September 1, 2022 09:12
@shortcuts
Copy link
Member Author

The file seemed correct to me before according to the doc, but let's try like that !

Yep me too but only with this schema it shows the "VALID" banner so I believe it will work now

algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Sep 1, 2022
algolia/api-clients-automation#979

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants