fix(specs): remove unretrievableAttributes from searchParams #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
changed the title
loicsay
force-pushed
the
fix/unretrievable-attributes
branch
from
dfd8ccc
to
dce4a78
Compare
loicsay
changed the title
loicsay
changed the title
|
The tests still requires them for the |
shortcuts
reviewed
Sep 8, 2022
loicsay
force-pushed
the
fix/unretrievable-attributes
branch
2 times, most recently
from
938ff89
to
6b54763
Compare
loicsay
commented
Sep 8, 2022
| @@ -62,8 +62,8 @@ Read the guides and requirements to: | |||
|
|
|||
| Test the generated clients by running: | |||
|
|
|||
| - The [`playground`](./playground) (see [documentation](https://api-clients-automation.netlify.app/docs/contributing/testing/playground.md)) | |||
| - The [`Common Test Suite`](./tests/) (see [documentation](https://api-clients-automation.netlify.app/docs/contributing/testing/common-test-suite.md)). | |||
| - The [`playground`](./playground) (see [documentation](https://api-clients-automation.netlify.app/docs/contributing/testing/playground)) | |||
There was a problem hiding this comment.
Not sure if it was an error in purpose @shortcuts ? 🙇
shortcuts
reviewed
Sep 8, 2022
| @@ -62,8 +62,8 @@ Read the guides and requirements to: | |||
|
|
|||
| Test the generated clients by running: | |||
|
|
|||
| - The [`playground`](./playground) (see [documentation](https://api-clients-automation.netlify.app/docs/contributing/testing/playground.md)) | |||
| - The [`Common Test Suite`](./tests/) (see [documentation](https://api-clients-automation.netlify.app/docs/contributing/testing/common-test-suite.md)). | |||
| - The [`playground`](./playground) (see [documentation](https://api-clients-automation.netlify.app/docs/contributing/testing/playground)) | |||
| @@ -233,9 +233,6 @@ | |||
| "attributesForFaceting": [ | |||
| "algolia" | |||
| ], | |||
| "unretrievableAttributes": [ | |||
There was a problem hiding this comment.
actually setSettings should not change, it's still an index setting, but this test should not include it anymore, since it's not a searchParams
There was a problem hiding this comment.
oops, wrong one! thanks 🙏
loicsay
force-pushed
the
fix/unretrievable-attributes
branch
from
6b54763
to
83949da
Compare
shortcuts
approved these changes
Sep 8, 2022
|
(I'll release once merged on main) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket:
Changes included:
🧪 Test