Skip to content

Commit

Permalink
fix(js): provide titles to submit and clear button
Browse files Browse the repository at this point in the history
  • Loading branch information
francoischalifour committed Feb 22, 2021
1 parent 434c565 commit 45944e4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/autocomplete-js/src/__tests__/autocomplete.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ describe('autocomplete-js', () => {
>
<button
class="aa-SubmitButton"
title="Submit"
type="submit"
>
<svg
Expand Down Expand Up @@ -128,6 +129,7 @@ describe('autocomplete-js', () => {
<button
class="aa-ClearButton"
hidden=""
title="Clear"
type="reset"
>
<svg
Expand Down
2 changes: 2 additions & 0 deletions packages/autocomplete-js/src/createAutocompleteDom.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ export function createAutocompleteDom<TItem extends BaseItem>({
const submitButton = createDomElement('button', {
class: classNames.submitButton,
type: 'submit',
title: 'Submit',
children: [SearchIcon({})],
});
const label = createDomElement('label', {
Expand All @@ -86,6 +87,7 @@ export function createAutocompleteDom<TItem extends BaseItem>({
const clearButton = createDomElement('button', {
class: classNames.clearButton,
type: 'reset',
title: 'Clear',
children: [ClearIcon({})],
});
const loadingIndicator = createDomElement('div', {
Expand Down

0 comments on commit 45944e4

Please sign in to comment.