Skip to content

Commit

Permalink
fix(*List): disable shortcuts in *List SearchBoxes (#1921)
Browse files Browse the repository at this point in the history
Before this commit, when using searchForFacetValues,
the default SearchBox shortcuts would be listening for.

Thus when hitting `/` or `s` it would try to focus
the SearchBox of RefinementList instead of something else.

fixes #1920

Note: we are not testing List.js right now, we need to fix that.
  • Loading branch information
vvo authored Jan 27, 2017
1 parent 3955cc7 commit 51a76ae
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@
"engines": {
"node": "^6.x.x || ^7.x.x"
},
"jest": {
"notify": true
},
"license": "MIT",
"author": {
"name": "Algolia, Inc.",
Expand Down
1 change: 1 addition & 0 deletions packages/react-instantsearch/src/components/List.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ class List extends Component {
this.setState({query: value});
searchForFacetValues(value);
}}
focusShortcuts={[]}
translate={translate}
onSubmit={e => {
e.preventDefault();
Expand Down

0 comments on commit 51a76ae

Please sign in to comment.