Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchForFacet values searchbox catches shortcut by default, should be disabled #1920

Closed
vvo opened this issue Jan 26, 2017 · 0 comments
Closed

SearchForFacet values searchbox catches shortcut by default, should be disabled #1920

vvo opened this issue Jan 26, 2017 · 0 comments
Assignees
@vvo
Labels
Scope: Widgets

Comments

@vvo
Copy link
Contributor

vvo commented Jan 26, 2017

No description provided.

@vvo vvo self-assigned this Jan 26, 2017
vvo pushed a commit that referenced this issue Jan 26, 2017
fix(searchForFacetValues): disable SearchBox shortcuts
497bacb 
Before this commit, hitting a keyboard default shortcut
like `/` or `s` would try to focus the SearchBox of a
RefinementList if any.

fixes #1920
vvo pushed a commit that referenced this issue Jan 26, 2017
fix(*List): disable shortcuts in *List SearchBoxes
bd46416 
Before this commit, when using searchForFacetValues,
the default SearchBox shortcuts would be listening for.

Thus when hitting `/` or `s` it would try to focus
the SearchBox of RefinementList instead of something else.

fixes #1920

Note: we are not testing List.js right now, we need to fix that.
@vvo vvo mentioned this issue Jan 26, 2017
Merged
@vvo vvo closed this as completed in #1921 Jan 27, 2017
vvo added a commit that referenced this issue Jan 27, 2017
@vvo
fix(*List): disable shortcuts in *List SearchBoxes (#1921)
51a76ae 
Before this commit, when using searchForFacetValues,
the default SearchBox shortcuts would be listening for.

Thus when hitting `/` or `s` it would try to focus
the SearchBox of RefinementList instead of something else.

fixes #1920

Note: we are not testing List.js right now, we need to fix that.
vvo pushed a commit that referenced this issue Feb 6, 2017
v3.0.0
9f7b8fe 
<a name="3.0.0"></a>
# [3.0.0](v2.2.5...v3.0.0) (2017-02-06)

### Bug Fixes

* ***List:** disable shortcuts in *List SearchBoxes (#1921) ([51a76ae](51a76ae)), closes [#1920](#1920)
* **Configure:** add configure parameters in search state (#1935) ([0971330](0971330)), closes [#1863](#1863)
* **Hits:** limit the hitComponent to be only a function (#1912) ([b3c9578](b3c9578))
* **Pagination:** fix and indicate when pagination is disabled ([5f20199](5f20199)), closes [#1938](#1938)
* **StarRating:** usage with filters (#1933) ([667e9d5](667e9d5))
* **withSearchBox:** keep displaying searchBox when no items found (#1930) ([30de4cd](30de4cd))

### Features

* **MultiRange:** indicate if a range has no refinements (#1926) ([80b6450](80b6450))
* **panel:** add a panel widget (#1889) ([594e1a1](594e1a1))
* **starRating:** indicate when any refinement has no effect ([c547ae5](c547ae5))
* **widgets:** default design for disabled states (#1929) ([31f010b](31f010b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vvo vvo

Labels
Scope: Widgets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vvo @bobylito