Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(engine): specify a non breaking node engine #2181

Merged
merged 1 commit into from
Jun 5, 2017
Merged

chore(engine): specify a non breaking node engine #2181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
7.10.0
1 change: 0 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
language: node_js
node_js: stable
addons:
apt:
sources:
Expand Down
6 changes: 6 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ A note about the branches used in this project:
You should do the dev and PR according to the target version. No new features
will be done on the maintenance version.

### Requirements

To run this project, you will need:

- Node.js >= v7.10.0 and <= 8, use nvm - [install instructions](https://github.com/creationix/nvm#install-script)

## Development

```sh
Expand Down
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@
"dist",
"dist-es5-module"
],
"engines": {
"node": "7.10.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I mislead you in adding this line, it should not be here because it will then produce unnecessary warnings when installed: https://docs.npmjs.com/files/package.json#engines

You can safely remove it. The only time this is useful is when you want your dev environment (for devs of the lib), to be tied to a specific nodejs version (this is useful)

},
"devDependencies": {
"autoprefixer": "^6.7.6",
"babel-cli": "^6.23.0",
Expand Down