-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(queryRules): add queryRuleCustomData widget #3600
feat(queryRules): add queryRuleCustomData widget #3600
Conversation
Deploy preview for instantsearchjs ready! Built with commit 2684259 |
e3f8f79
to
01dac7f
Compare
b5892e1
to
b3745e5
Compare
GitHub seems to also display the changes introduced in #3599, that's weird. |
These changes seem to be a different PR? Not sure what to review here |
I think the |
As said in #3600 (comment) I think that's a GitHub bug. You can ignore the changes related to Storybook. Edit: I rebased again, should be fixed! |
01dac7f
to
6add930
Compare
src/widgets/query-rule-custom-data/__tests__/query-rule-custom-data-test.ts
Outdated
Show resolved
Hide resolved
c9afe71
to
e1998bf
Compare
b5d3121
to
3f515f6
Compare
Without custom CSS classes, the inserted I think we should create an InstantSearch.css spec for this widget with the following markup: <div class="ais-QueryRuleCustomData"></div> It would imply adding a WDYT? |
makes sense to me! |
d1321b2
to
a624a14
Compare
57a4a49
to
2684259
Compare
# [3.3.0](v3.2.1...v3.3.0) (2019-04-11) ### Bug Fixes * **connectQueryRules:** improve tracked refinement type ([#3648](#3648)) ([e16ad57](e16ad57)) * **currentRefinements:** don't rely on ([#3672](#3672)) ([cd64bcf](cd64bcf)) * **queryRuleCustomData:** add default template ([#3650](#3650)) ([83e9eaa](83e9eaa)) * **QueryRuleCustomData:** pass data as object to templates ([#3647](#3647)) ([b8f8b4e](b8f8b4e)) * **queryRules:** fix types and stories ([#3670](#3670)) ([ba6e2e6](ba6e2e6)) * **routing:** apply windowTitle on first load ([#3669](#3669)) ([d553502](d553502)), closes [#3667](#3667) * **routing:** support parsing URLs with up to 100 refinements ([#3671](#3671)) ([6ddcfb6](6ddcfb6)) * **RoutingManager:** avoid stale uiState ([#3630](#3630)) ([e1588aa](e1588aa)) * **types:** improve InstantSearch types ([#3651](#3651)) ([db9b91e](db9b91e)) * **ua:** Update the User-Agent to use the new format ([#3616](#3616)) ([ab84c57](ab84c57)) ### Features * **infiniteHits:** add previous button ([#3645](#3645)) ([2c9e38d](2c9e38d)) * **queryRules:** add connectQueryRules connector ([#3597](#3597)) ([924cd99](924cd99)), closes [#3599](#3599) [#3600](#3600) * **queryRules:** add context features to Query Rules ([#3617](#3617)) ([922879e](922879e)), closes [#3602](#3602) ### Reverts * feat(infiniteHits): add previous button ([214c0fc](214c0fc))
This is the 2nd PR in the series "Merchandized Query Rules".
Summary
This creates the
queryRuleCustomData
widget, responsible for showing custom data (userData
) coming from Query Rules.Current solution
Right now, we can leverage the
connectHits
connector to show a banner with InstantSearch.js.See live example →
The goal of the widget is to simplify this solution.
Widget usage
Given this
userData
:When the query rule is matched, the engine returns:
You would use the
queryRuleCustomData
widget:API
transformItems
The function to change the data sent by the engine before giving it to the template.
container
The container of the widget.
templates
The templates to display for the custom data (
userData
).Stories
See stories →
Related
connectQueryRules
queryRuleContext