feat(react-instantsearch-ssr-nextjs): turn Next.js RSC/SSR solution into its own package
#5830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahdayan
force-pushed
the
feat/experimental-rsc-and-next-app-dir-support-package
branch
from
f779bd2 to
1dcd81c
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f779bd2:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d5de2eb:
|
sarahdayan
force-pushed
the
feat/experimental-rsc-and-next-app-dir-support-package
branch
from
1eee332 to
2642653
Compare
Haroenv
reviewed
Aug 31, 2023
Comment on lines
+18
to
+19
| "react-instantsearch-router-nextjs": "7.0.1", | ||
| "react-instantsearch-ssr-nextjs": "7.0.1" |
There was a problem hiding this comment.
do you think we could have instead one package react-instantsearch-nextjs that has both?
There was a problem hiding this comment.
The router only works for pages while the other only works for app though 😅
There was a problem hiding this comment.
As long as it's experimental I'd keep it as a separate package. But I dig the idea of having a single package for nextjs specific things in the future.
sarahdayan
force-pushed
the
feat/experimental-rsc-and-next-app-dir-support-package
branch
from
e32d4b6 to
594d759
Compare
aymeric-giraudet
force-pushed
the
feat/experimental-rsc-and-next-app-dir-support-package
branch
from
664bc7d to
2fbad76
Compare
sarahdayan
commented
Sep 4, 2023
packages/react-instantsearch-ssr-nextjs/src/NextInstantSearchSSR.tsx
Outdated
Show resolved
Hide resolved
aymeric-giraudet
merged commit 2a74838
into
feat/experimental-rsc-and-next-app-dir-support
aymeric-giraudet
deleted the
feat/experimental-rsc-and-next-app-dir-support-package
branch
aymeric-giraudet
added a commit
that referenced
this pull request
Sep 19, 2023
…d Next.js app directory (#5827) * feat(rsc): very experimental working PoC for Next.js app dir * feat(`react-instantsearch-ssr-nextjs`): turn Next.js RSC/SSR solution into its own package (#5830) * chore: create `react-instantsearch-ssr-nextjs` package * chore: move Next.js RSC/SSR utilities to dedicated package * docs: update Next App Router example with new package * refactor: split context and usage Hook * feat: pass `ServerInsertedHTMLContext` ourselves * refactor: clean up importqs * style: lint * docs: build example in CodeSandbox * ci: use Next.js 13 compatible Node version * ci: use compatible Node version * test: add version test files * upgrade next version in all examples * chore: remove unnecessary exports * chore: remove weirdo character * build: resolve Next for ESM * refactor: move as much logic in new package as possible + dynamicWidgets support * routing --------- Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com> * fix other next examples * update deps in new package * fix build/tests? * bundlesize * React import in app-dir example * feat(RSC): add warnings (#5840) * bump node version a bit * avoid double results injection * fix: routing when going from one InstantSearch page to another Co-authored-by: Burak Tamtürk <buraktamturk@gmail.com> * fix tests * changed naming * fix build * forgot to rename dir * fix multi index * revert to renderToString * remove doctoc line * readme * changed use * update peerDep * Apply suggestions from code review Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> --------- Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com> Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Burak Tamtürk <buraktamturk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon Aymeric's work and extracts the wrapper in its own package, to leave the minimal amount of code in react-instantsearch-core.
Some notes that will probably need to be adressed during real implementation:
historyRouter()and conditionally returning a composited URL using Next.js Hooks. It might be interesting to provide a friendlier interface for building this URL