fix(InstantSearchNext): do not scroll on push #5861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymeric-giraudet
requested review from
a team,
dhayab and
sarahdayan
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f017038:
|
Haroenv
approved these changes
Sep 21, 2023
|
@aymeric-giraudet @Haroenv how can I add back scrollTo? I am using pagination widget and on page change I am staying in the same spot without scrolling to the top. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
router.pushscrolls to the top by default, so I made this PR to disable that as we don't do this is in other flavors.We could make it into an option but I think it's best to leave it like that, it probably makes more sense to scroll to the top depending on the widget, for example Pagination, whereas it wouldn't make sense with InfiniteHits.
Also included a small fix to the README file