Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use mainHelper consistently #5875

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented Oct 2, 2023

This PR has been extracted from changes in #5123, where they were unrelated and added a bit of noise.

This has the side effect of fixing an issue related to current refinements not respecting facet values order (see this comment).

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit abcd5a4:

Sandbox Source
InstantSearch.js Configuration
react-instantsearch-app Configuration
example-react-instantsearch-default-theme Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-vue-instantsearch-default-theme Configuration

@dhayab dhayab requested review from sarahdayan and Haroenv October 2, 2023 14:03
@dhayab dhayab enabled auto-merge (squash) October 4, 2023 14:49
@dhayab dhayab merged commit 121d13a into master Oct 4, 2023
3 checks passed
@dhayab dhayab deleted the fix/use-mainhelper-consistently branch October 4, 2023 15:02
dhayab added a commit that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants