feat(instantsearch): allow the insights middleware to be added in answer to a server setting #5883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e10f7ea:
|
Haroenv
reviewed
Oct 10, 2023
dhayab
force-pushed
the
feat/insights-dashboard-support
branch
from
eb4fc4e to
4afc579
Compare
dhayab
changed the base branch from
master
to
feat/insights-default-undefined
dhayab
force-pushed
the
feat/insights-dashboard-support
branch
from
4afc579 to
bccb6b0
Compare
sarahdayan
approved these changes
Oct 17, 2023
packages/instantsearch.js/src/middlewares/createInsightsMiddleware.ts
Outdated
Show resolved
Hide resolved
packages/instantsearch.js/src/lib/__tests__/InstantSearch-test.tsx
Outdated
Show resolved
Hide resolved
dhayab
commented
Oct 17, 2023
packages/instantsearch.js/src/lib/__tests__/InstantSearch-test.tsx
Outdated
Show resolved
Hide resolved
dhayab
commented
Oct 17, 2023
packages/instantsearch.js/src/lib/__tests__/InstantSearch-test.tsx
Outdated
Show resolved
Hide resolved
dhayab
commented
Oct 17, 2023
packages/instantsearch.js/src/lib/__tests__/InstantSearch-test.tsx
Outdated
Show resolved
Hide resolved
dhayab
commented
Oct 17, 2023
packages/instantsearch.js/src/lib/__tests__/InstantSearch-test.tsx
Outdated
Show resolved
Hide resolved
dhayab
commented
Oct 17, 2023
packages/instantsearch.js/src/lib/__tests__/InstantSearch-test.tsx
Outdated
Show resolved
Hide resolved
dhayab
commented
Oct 17, 2023
packages/instantsearch.js/src/lib/__tests__/InstantSearch-test.tsx
Outdated
Show resolved
Hide resolved
dhayab
commented
Oct 17, 2023
packages/instantsearch.js/src/lib/__tests__/InstantSearch-test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
sarahdayan
approved these changes
Oct 17, 2023
JasonBerry
approved these changes
Oct 18, 2023
Haroenv
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
insightsis undefined, the Insights middleware can be initialized in answer to a server setting, received with the initial results.FX-2643