Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(requests): don't fire a request when there are no widgets #6185

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented May 7, 2024

Still to investigate further. I believe this won't have any negative repercussions, but at least some test cases will need to be written, as these don't seem to exist yet.

Comes out of an attempt to fix #6174 before realising that behaviour was happening for a different reason

Still to investigate further. I believe this won't have any negative repercussions, but at least some test cases will need to be written, as these don't seem to exist yet.

Comes out of an attempt to fix #6174 before realising that behaviour was happening

Likely optimisation possible once this is done is to remove extra checks in:
- https://github.com/algolia/instantsearch/blob/1405aebb52cd84b02a4f645ee5395763f4878b79/packages/instantsearch.js/src/widgets/index/index.ts#L477-L479
- https://github.com/algolia/instantsearch/blob/1b683c5ebbcae4a77a43ff2034da406c9eb0dbc4/packages/instantsearch.js/src/lib/InstantSearch.ts#L671-L681
Copy link

codesandbox-ci bot commented May 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2fe1910:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant