refactor: introduce instantsearch-core
#6371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6232a64:
|
Haroenv
previously requested changes
Sep 25, 2024
Haroenv
force-pushed
the
feat/instantsearch-core
branch
3 times, most recently
from
9ea85df
to
113a313
Compare
Haroenv
force-pushed
the
feat/instantsearch-core
branch
from
113a313
to
48a2251
Compare
Haroenv
force-pushed
the
feat/instantsearch-core
branch
from
48a2251
to
790b781
Compare
Haroenv
dismissed
their stale review
I've since refactored the PR, so can no longer approve it
Haroenv
changed the title
instantsearch-coreinstantsearch-core
Haroenv
force-pushed
the
next
branch
2 times, most recently
from
a94e292
to
be739e9
Compare
Haroenv
force-pushed
the
feat/instantsearch-core
branch
from
790b781
to
7ddc82d
Compare
Haroenv
force-pushed
the
feat/instantsearch-core
branch
from
7ddc82d
to
c474440
Compare
Haroenv
force-pushed
the
feat/instantsearch-core
branch
from
c474440
to
6232a64
Compare
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Haroenv
added a commit
that referenced
this pull request
Oct 25, 2024
* feat: introduce `instantsearch-core` package * Apply suggestions from code review Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> --------- Co-authored-by: Haroen Viaene <hello@haroen.me> Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Haroenv
added a commit
that referenced
this pull request
Oct 25, 2024
* feat: introduce `instantsearch-core` package * Apply suggestions from code review Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> --------- Co-authored-by: Haroen Viaene <hello@haroen.me> Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new
instantsearch-coreand extracts a first set of easy-to-migrate types.The process will be iterative with small PRs to avoid a huge diff.
The moved types are still re-exported, as they are useful for users of the library, and all types are already exported in current instantsearch.js. We can if needed establish a pattern for internal types later, but that's likely not needed initially.
FX-3094
FX-3095