Fix bug that identify wrongly some TS packages as Definetely Typed #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
approved these changes
Dec 7, 2022
|
Thanks! This fix won't automatically be taken in account, but for new/updated packages it will work already. I'll launch a full reindex as well parallel soon, but that will take a long time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue that appears to be a data problem with
npm-searchindex listing yup (we've only seen a single library so far) as non-TS library.To solve it, applies the suggestion by @jablko and reverse the logic in the
getTypeScriptSupportfunction, preventing yup, or other libraries written in TypeScript from being flagged as definitely typed even if an outdated/deprecated Definitely Typed reference exists.closes #1089