Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that identify wrongly some TS packages as Definetely Typed #1091

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

Josehower
Copy link
Contributor

This PR solves the issue that appears to be a data problem with npm-search index listing yup (we've only seen a single library so far) as non-TS library.

To solve it, applies the suggestion by @jablko and reverse the logic in the getTypeScriptSupport function, preventing yup, or other libraries written in TypeScript from being flagged as definitely typed even if an outdated/deprecated Definitely Typed reference exists.

closes #1089

@Haroenv Haroenv merged commit af49b4f into algolia:master Dec 7, 2022
@Haroenv
Copy link
Collaborator

Haroenv commented Dec 7, 2022

Thanks! This fix won't automatically be taken in account, but for new/updated packages it will work already. I'll launch a full reindex as well parallel soon, but that will take a long time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getObject() for Yup reports types of DefinitelyTyped
2 participants