refactor(indexutils): remove omit with path

algolia · May 17, 2019 · 039afcb · 039afcb
1 parent 2e8d630
commit 039afcb
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/packages/react-instantsearch-core/src/core/__tests__/indexUtils.js b/packages/react-instantsearch-core/src/core/__tests__/indexUtils.js
@@ -227,6 +227,7 @@ describe('utility method for manipulating the search state', () => {
         namespace: {},
       });
     });
+
     it('get results', () => {
       const searchResults = { results: { hits: ['some'] } };
 
@@ -235,6 +236,7 @@ describe('utility method for manipulating the search state', () => {
       expect(results).toEqual({ hits: ['some'] });
     });
   });
+
   describe('when there are multiple index', () => {
     let context = { multiIndexContext: { targetedIndex: 'first' } };
     it('refine with no namespace', () => {

diff --git a/packages/react-instantsearch-core/src/core/indexUtils.js b/packages/react-instantsearch-core/src/core/indexUtils.js
@@ -1,4 +1,4 @@
-import { has, omit as lodashOmit, get } from 'lodash';
+import { has, get } from 'lodash';
 import { omit } from './utils';
 
 export function getIndexId(context) {
@@ -269,5 +269,15 @@ function cleanUpValueWithMultiIndex({
     };
   }
 
-  return lodashOmit(searchState, `indices.${indexId}.${id}`);
+  if (indexSearchState) {
+    return {
+      ...searchState,
+      indices: {
+        ...searchState.indices,
+        [indexId]: omit(indexSearchState, [id]),
+      },
+    };
+  }
+
+  return searchState;
 }