fix(connectRange): use the same behaviour for currentRefinement in ge…

…tMetadata (#923)
algolia · Feb 5, 2018 · 08917b6 · 08917b6
1 parent 8442cbf
commit 08917b6
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 13 deletions.
diff --git a/packages/react-instantsearch/src/connectors/connectRange.js b/packages/react-instantsearch/src/connectors/connectRange.js
@@ -107,6 +107,13 @@ function getCurrentRefinement(props, searchState, currentRange, context) {
   return refinement;
 }
 
+function getCurrentRefinementWithRange(refinement, range) {
+  return {
+    min: refinement.min !== undefined ? refinement.min : range.min,
+    max: refinement.max !== undefined ? refinement.max : range.max,
+  };
+}
+
 function nextValueForRefinement(hasBound, isReset, range, value) {
   let next;
   if (!hasBound && range === value) {
@@ -217,7 +224,7 @@ export default createConnector({
       max: rangeMax,
     };
 
-    const { min: valueMin, max: valueMax } = getCurrentRefinement(
+    const currentRefinement = getCurrentRefinement(
       props,
       searchState,
       this._currentRange,
@@ -228,10 +235,10 @@ export default createConnector({
       min: rangeMin,
       max: rangeMax,
       canRefine: count.length > 0,
-      currentRefinement: {
-        min: valueMin === undefined ? rangeMin : valueMin,
-        max: valueMax === undefined ? rangeMax : valueMax,
-      },
+      currentRefinement: getCurrentRefinementWithRange(
+        currentRefinement,
+        this._currentRange
+      ),
       count,
       precision,
     };
@@ -300,10 +307,10 @@ export default createConnector({
         attributeName: props.attributeName,
         value: nextState =>
           refine(props, nextState, {}, this._currentRange, this.context),
-        currentRefinement: {
-          min: minValue,
-          max: maxValue,
-        },
+        currentRefinement: getCurrentRefinementWithRange(
+          { min: minValue, max: maxValue },
+          { min: minRange, max: maxRange }
+        ),
       });
     }
 

diff --git a/packages/react-instantsearch/src/connectors/connectRange.test.js b/packages/react-instantsearch/src/connectors/connectRange.test.js
@@ -470,7 +470,7 @@ describe('connectRange', () => {
           {
             label: '5 <= wot',
             attributeName: 'wot',
-            currentRefinement: { min: 5, max: undefined },
+            currentRefinement: { min: 5, max: 100 },
             // Ignore clear, we test it later
             value: metadata.items[0].value,
           },
@@ -505,7 +505,7 @@ describe('connectRange', () => {
           {
             label: 'wot <= 10',
             attributeName: 'wot',
-            currentRefinement: { min: undefined, max: 10 },
+            currentRefinement: { min: 0, max: 10 },
             value: metadata.items[0].value,
           },
         ],
@@ -753,7 +753,7 @@ describe('connectRange', () => {
           {
             label: '5 <= wot',
             attributeName: 'wot',
-            currentRefinement: { min: 5, max: undefined },
+            currentRefinement: { min: 5, max: 100 },
             // Ignore clear, we test it later
             value: metadata.items[0].value,
           },
@@ -792,7 +792,7 @@ describe('connectRange', () => {
           {
             label: 'wot <= 10',
             attributeName: 'wot',
-            currentRefinement: { min: undefined, max: 10 },
+            currentRefinement: { min: 0, max: 10 },
             value: metadata.items[0].value,
           },
         ],