fix(connectQueryRules): avoid to throw an error with undefined values (…

…#2436)
algolia · May 14, 2019 · 1e18287 · 1e18287
1 parent 729a3a4
commit 1e18287
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/packages/react-instantsearch-core/src/connectors/__tests__/connectQueryRules.ts b/packages/react-instantsearch-core/src/connectors/__tests__/connectQueryRules.ts
@@ -132,6 +132,23 @@ describe('connectQueryRules', () => {
         expect(searchParameters.ruleContexts).toEqual(['initial-rule']);
       });
 
+      it('does not throw an error with search state that contains `undefined` value', () => {
+        const props: QueryRulesProps = {
+          ...defaultProps,
+          trackedFilters: {
+            price: values => values,
+          },
+        };
+
+        const searchState = {
+          refinementList: undefined,
+        };
+
+        expect(() => {
+          getSearchParameters(SearchParameters.make({}), props, searchState);
+        }).not.toThrow();
+      });
+
       it('sets ruleContexts based on range', () => {
         const priceSpy = jest.fn(values => values);
         const props: QueryRulesProps = {

diff --git a/packages/react-instantsearch-core/src/connectors/connectQueryRules.ts b/packages/react-instantsearch-core/src/connectors/connectQueryRules.ts
@@ -66,7 +66,9 @@ function getRefinements(
 ): TrackedFilterRefinement[] {
   const refinements = Object.keys(searchState)
     .filter(
-      widgetKey => typeof searchState[widgetKey][attribute] !== 'undefined'
+      widgetKey =>
+        searchState[widgetKey] !== undefined &&
+        searchState[widgetKey][attribute] !== undefined
     )
     .map(widgetKey => getWidgetRefinements(attribute, widgetKey, searchState))
     .reduce((acc, current) => acc.concat(current), []); // flatten the refinements