refactor(lodash): isEmpty

reusing objectHasKeys strategy from the helper IFW-736
algolia · May 15, 2019 · 559aa4f · 559aa4f
1 parent cedf564
commit 559aa4f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/packages/react-instantsearch-core/src/connectors/connectGeoSearch.js b/packages/react-instantsearch-core/src/connectors/connectGeoSearch.js
@@ -1,4 +1,4 @@
-import { isEmpty } from 'lodash';
+import { objectHasKeys } from '../core/utils';
 import createConnector from '../core/createConnector';
 import {
   getResults,
@@ -73,7 +73,7 @@ const getCurrentRefinement = (props, searchState, context) => {
     {}
   );
 
-  if (isEmpty(refinement)) {
+  if (!objectHasKeys(refinement)) {
     return;
   }
 

diff --git a/packages/react-instantsearch-core/src/connectors/connectNumericMenu.js b/packages/react-instantsearch-core/src/connectors/connectNumericMenu.js
@@ -1,5 +1,6 @@
-import { find, isEmpty } from 'lodash';
+import { find } from 'lodash';
 import PropTypes from 'prop-types';
+import { objectHasKeys } from '../core/utils';
 import createConnector from '../core/createConnector';
 import {
   cleanUpValue,
@@ -156,7 +157,7 @@ export default createConnector({
     if (!items.some(item => item.value === '')) {
       items.push({
         value: '',
-        isRefined: isEmpty(refinedItem),
+        isRefined: !objectHasKeys(refinedItem),
         noRefinement: !stats,
         label: 'All',
       });

diff --git a/packages/react-instantsearch-core/src/core/utils.ts b/packages/react-instantsearch-core/src/core/utils.ts
@@ -62,3 +62,7 @@ export function addQueryID(hits, queryID) {
     __queryID: queryID,
   }));
 }
+
+export function objectHasKeys(object) {
+  return object && Object.keys(object).length > 0;
+}