This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(List): render children list only when required #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-instantsearch ready! Built with commit d455524 https://deploy-preview-1472--react-instantsearch.netlify.com |
Haroenv
suggested changes
Aug 6, 2018
| .map(child => this.renderItem(child, item))} | ||
| </ul> | ||
| ); | ||
| const isItemHasChildren = item.items && Boolean(item.items.length); |
There was a problem hiding this comment.
hasChildren should be clear enough too right? This name now is pretty unclear :)
There was a problem hiding this comment.
Indeed. But I prefer to be explicit with something like itemHasChildren. WDYT?
There was a problem hiding this comment.
itemHasChildren also would be fine :)
samouss
force-pushed
the
fix/list-empty-children
branch
from
8e90e7b to
d455524
Compare
samouss
added a commit
that referenced
this pull request
Aug 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a followup of #1459. It adds tests to the
Listcomponent (only for the changes not the all component). Now we render the children list only when theitemcontains an non empty array ofitems. The same condition is applied on the classitem--parent.Before
After
Note: The arrow is not present on the latter since we removed the class.