Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

HeirachialMenu empty array parent--item #1459

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

digitalcraft
Copy link

There is more context in AlgoliaPartners#ps-digital8 channel.
Image of Bug

The bug happens when a product is in a level 1 category and a level 2 category.

There is more context in AlgoliaPartners#ps-digital8 channel.
![Image of Bug](https://i.imgur.com/q35MbR5.png)

The bug happens when a product is in a level 1 category and a level 2 category.
@algobot
Copy link
Contributor

algobot commented Jul 26, 2018

Deploy preview for react-instantsearch ready!

Built with commit 829cb24

https://deploy-preview-1459--react-instantsearch.netlify.com

@Haroenv
Copy link
Contributor

Haroenv commented Jul 27, 2018

This probably needs a new test to show the behaviour this fixes, WDYT?

Thanks for your contribution though! ❤️

Also linting is crying because I think you need to write it on more lines or something

@Haroenv Haroenv requested a review from samouss July 27, 2018 08:12
@samouss samouss changed the base branch from master to fix/list-empty-children August 6, 2018 13:13
@samouss samouss merged commit bb85fb5 into algolia:fix/list-empty-children Aug 6, 2018
@samouss
Copy link
Collaborator

samouss commented Aug 6, 2018

I wasn't able to update the PR directly so I merged the branch in a new branch that I can edit (thanks @Haroenv for the idea). Here is the new PR #1472.

cc @digitalcraft

samouss pushed a commit that referenced this pull request Aug 7, 2018
samouss added a commit that referenced this pull request Aug 7, 2018
* fix(List): remove class parent when items is empty

* fix(List): empty array parent--item (#1459)

* fix(List): rename variable isItemHasChildren to itemHasChildren
samouss added a commit that referenced this pull request Aug 16, 2018
<a name="5.2.3"></a>
## [5.2.3](v5.2.2...v5.2.3) (2018-08-16)

### Bug Fixes

* Allow object as type for Root (closes [#1446](#1446)) ([#1461](#1461)) ([7c2317b](7c2317b))
* **List:** render children list only when required ([#1472](#1472)) ([9eb2cbb](9eb2cbb)), closes [#1459](#1459)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants