This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(deps): fix "too much recursion" error with circular deps #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
eunjae-lee and
yannickcr
and removed request for
a team
francoischalifour
force-pushed
the
fix/deps-compare-circular
branch
from
1d73bb4 to
3f48ef6
Compare
|
Deploy preview for react-instantsearch ready! Built with commit 3f48ef6 https://deploy-preview-2899--react-instantsearch.netlify.com |
eunjae-lee
approved these changes
Mar 5, 2020
yannickcr
approved these changes
Mar 6, 2020
Haroenv
reviewed
Mar 6, 2020
| @@ -15864,6 +15864,11 @@ react-fast-compare@^2.0.2: | |||
| resolved "https://registry.yarnpkg.com/react-fast-compare/-/react-fast-compare-2.0.4.tgz#e84b4d455b0fec113e0402c329352715196f81f9" | |||
| integrity sha512-suNP+J1VU1MWFKcyt7RtjiSWUjvidmQSlqu+eHslq+342xCbGTYmC0mEhPCOHxlW0CywylOC1u2DFAT+bv4dBw== | |||
|
|
|||
| react-fast-compare@^3.0.0: | |||
There was a problem hiding this comment.
how come nothing is removed from the lockfile? Does another package already use it?
There was a problem hiding this comment.
Yes, Storybook.
|
Could this be released? |
Haroenv
added a commit
that referenced
this pull request
Mar 18, 2020
|
Thanks for the ping, 6.4.0 is released :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since React InstantSearch 6, there's an issue with props equality with circular dependencies because of the dep
fast-deep-equalthat was introduced.Errors like "too much recursion" appeared in browsers (mostly Firefox). More and more users face this issue, and I also faced this issue in some apps I built.
I tried upgrading the
fast-deep-equaldependency to^3.1.0which supposedly fixes this, but the build seems broken since I get an error about no default exports exist in this package.I tried
react-fast-compareand although it's a bit bigger, it fixes the issue. I tried in the Next app that the user sent.